-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #465, Added UT tests for cFE ES Api #1623
Merged
astrogeco
merged 1 commit into
nasa:integration-candidate
from
pepepr08:fix465-es-api-ut
Jun 23, 2021
Merged
Fix #465, Added UT tests for cFE ES Api #1623
astrogeco
merged 1 commit into
nasa:integration-candidate
from
pepepr08:fix465-es-api-ut
Jun 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepepr08
added
the
CCB:Ready
Ready for discussion at the Configuration Control Board (CCB)
label
Jun 15, 2021
pepepr08
force-pushed
the
fix465-es-api-ut
branch
2 times, most recently
from
June 15, 2021 21:42
45e1ae5
to
a9db63b
Compare
CCB:2021-06-16 APPROVED
|
pepepr08
force-pushed
the
fix465-es-api-ut
branch
from
June 16, 2021 18:19
a9db63b
to
c9797d0
Compare
pepepr08
force-pushed
the
fix465-es-api-ut
branch
2 times, most recently
from
June 16, 2021 18:46
744da71
to
3b93965
Compare
jphickey
requested changes
Jun 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calls to UtAssert_INT32_EQ look good. Only minor issue I see is with respect to "munging" the task ID - need to use the macros for this (CFE_ES_TASKID_C and CFE_RESOURCEID_TO_ULONG) so it will still work when strict type checking is turned on.
Test CFE_ES_ReloadApp bad AppID, core app, file doesn't exist Test CFE_ES_GetAppID: NULL AppID pointer Test CFE_ES_GetAppIDByName: NULL AppID pointer Test CFE_ES_GetAppIDByName: NULL name pointer Test CFE_ES_DeleteChildTask: Task inactive/invalid case Test CFE_ES_RegisterCDS: NULL handle and NULL name
pepepr08
force-pushed
the
fix465-es-api-ut
branch
from
June 16, 2021 19:30
3b93965
to
a0e89a8
Compare
astrogeco
added
CCB:Approved
Indicates code review and approval by community CCB
and removed
CCB:Ready
Ready for discussion at the Configuration Control Board (CCB)
labels
Jun 17, 2021
jphickey
approved these changes
Jun 17, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 23, 2021
nasa/cFE#1623, Added UT tests for cFE ES Api nasa/cFE#1634, Expand CDS Functional Tests.
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 24, 2021
*Combines* - nasa/elf2cfetbl#81 - nasa/tblCRCTool#52 - nasa/ci_lab#88 - nasa/sch_lab#83 - nasa/sample_app#150 - nasa/sample_lib#64 - nasa/to_lab#100 *Includes* - nasa/cFE#1630, correct path to users guide warning log - nasa/cFE#1621, add additional test cases for Child Tasks - nasa/cFE#1608, Add cfe functional tests to CI - nasa/cFE#1627, rename/clean CFE coverage assert macros - nasa/cFE#1623, Added UT tests for cFE ES Api - nasa/cFE#1634, Expand CDS Functional Tests. - nasa/cFE#1633, add test log file - nasa/cFE#1594, Event ID updates - nasa/cFE#1624, scrub all UT_Report calls - nasa/osal#1066, implement missing parameter/retcode test permutations - nasa/cFS-GroundSystem#182, Add test start command script for cmdUtil - nasa/tblCRCTool#51, add printf conversion casts ** Implement Coding Standard in CodeQL ** - nasa/cFS-GroundSystem#180 - nasa/elf2cfetbl#80 - nasa/tblCRCTool#49 - nasa/ci_lab#87 - nasa/sch_lab#79 - nasa/sample_app#149 - nasa/sample_lib#63 - nasa/to_lab#99
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 24, 2021
*Combines* - nasa/cFE#1632, v6.8.0-rc1+dev726 - nasa/osal#1079, v5.1.0-rc1+dev548 - nasa/ci_lab#88, v2.4.0-rc1+dev42 - nasa/sch_lab#83, v2.4.0-rc1+dev40 - nasa/sample_app#150, v1.2.0-rc1+dev66 - nasa/sample_lib#64, v1.2.0-rc1+dev38 - nasa/to_lab#100, v2.4.0-rc1+dev49 - nasa/elf2cfetbl#81, v3.2.0-rc1+dev30 - nasa/tblCRCTool#52, v1.2.0-rc1+dev33 - nasa/cFS-GroundSystem#183, v2.2.0-rc1+dev52 *Includes* - nasa/cFE#1630, correct path to users guide warning log - nasa/cFE#1621, add additional test cases for Child Tasks - nasa/cFE#1608, Add cfe functional tests to CI - nasa/cFE#1627, rename/clean CFE coverage assert macros - nasa/cFE#1623, Added UT tests for cFE ES Api - nasa/cFE#1634, Expand CDS Functional Tests. - nasa/cFE#1633, add test log file - nasa/cFE#1594, Event ID updates - nasa/cFE#1624, scrub all UT_Report calls - nasa/osal#1066, implement missing parameter/retcode test permutations - nasa/cFS-GroundSystem#182, Add test start command script for cmdUtil - nasa/tblCRCTool#51, add printf conversion casts ** Implement Coding Standard in CodeQL ** - nasa/cFS-GroundSystem#180 - nasa/elf2cfetbl#80 - nasa/tblCRCTool#49 - nasa/ci_lab#87 - nasa/sch_lab#79 - nasa/sample_app#149 - nasa/sample_lib#63 - nasa/to_lab#99 Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #465
Completed code coverage on the following functions:
Testing performed
Steps taken to test the contribution:
Expected behavior changes
Percentage of lines covered should increment.
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Jose F. Martinez Pedraza/NASA GSFC